Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typemod.modtype_of_package should be exported so that it is usable via compiler-libs #6842

Closed
vicuna opened this issue Apr 16, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Apr 16, 2015

Original bug ID: 6842
Reporter: furuse
Assigned to: @garrigue
Status: closed (set by @xavierleroy on 2016-12-07T10:48:55Z)
Resolution: fixed
Priority: normal
Severity: trivial
Version: 4.02.1
Fixed in version: 4.02.2+dev / +rc1
Category: ~DO NOT USE (was: OCaml general)

Bug description

I found that there is no function exported to convert a packaged module type to a normal module type. Namely, modtype_of_package. I thought it is trivial work but looking ad the code of it and package_constraints, it seems more complex.

Without it, it is hard to write OCaml tools which handle packaged module types. It would be nice if it is exported to typemod.mli and available in compiler-libs.

Thanks,

@vicuna

This comment has been minimized.

Copy link
Author

commented Apr 23, 2015

Comment author: @garrigue

Typemod.modtype_of_package is now exported.
In trunk and 4.02, at revisions 16033 and 16034.

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.