Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explanation of total of Hashtbl.hash_param is not right. #6869

Closed
vicuna opened this issue May 14, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented May 14, 2015

Original bug ID: 6869
Reporter: furuse
Assigned to: @mshinwell
Status: closed (set by @xavierleroy on 2016-12-07T10:49:22Z)
Resolution: fixed
Priority: normal
Severity: major
Version: 4.02.1
Fixed in version: 4.02.2+dev / +rc1
Category: standard library
Monitored by: @gasche

Bug description

hashtbl.mli says about Hashtbl.hash_param:

Hashing performs a breadth-first, left-to-right traversal
of the structure [x], stopping after [meaningful] meaningful nodes
were encountered, or [total] nodes (meaningful or not) were
encountered.

The value of [total] is actually capped to HASH_QUEUE_SIZE=256 in byterun/hash.c therefore specifying larger than 256 is equivalent with 256. This should be noted in the comment.

@vicuna

This comment has been minimized.

Copy link
Author

commented May 19, 2015

Comment author: @mshinwell

Fixed in 4.02

@vicuna vicuna closed this Dec 7, 2016

@vicuna vicuna added the stdlib label Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.