Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More efficient ifprintf implementation #7034

Closed
vicuna opened this issue Oct 31, 2015 · 1 comment
Closed

More efficient ifprintf implementation #7034

vicuna opened this issue Oct 31, 2015 · 1 comment

Comments

@vicuna
Copy link

@vicuna vicuna commented Oct 31, 2015

Original bug ID: 7034
Reporter: @yallop
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2017-02-16T14:14:42Z)
Resolution: fixed
Priority: normal
Severity: feature
Category: standard library
Tags: patch
Related to: #6017

Bug description

The printf functions currently share the core of the their implementation. As discussed in PR6017, this leads to unnecessary work in the ifprintf family of functions. The following GitHub pull request implements ifprintf more efficiently:

https://github.com/ocaml/ocaml/pull/267
@vicuna
Copy link
Author

@vicuna vicuna commented Oct 31, 2015

Comment author: @yallop

Merged in trunk here:

https://github.com/ocaml/ocaml/commit/b2e81d78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants