Loss of ppx context in toplevel after an exception

[vicuna]

Original bug ID: 7098
Reporter: @whitequark
Assigned to: @alainfrisch
Status: closed (set by @xavierleroy on 2017-02-16T14:18:07Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.02.3
Fixed in version: 4.03.0+dev / +beta1
Category: ~DO NOT USE (was: OCaml general)
Monitored by: @alainfrisch

Bug description

$ cat t.ml
#use "topfind";;
#require "ppx_deriving.std";;
#require "ppx_import";;

type t = int [@@deriving show];;
type u = int [@@deriving nonexistent];;
type t = int [@@deriving show];;
$ ocaml <t.ml
[snip]
Cannot locate deriver show

Note that the first [@@deriving show] succeeds, but the second one fails.

Also note the ocaml <t.ml (otherwise the toplevel will stop on the first error), and that if you remove #require "ppx_import";;, the bug stops manifesting itself.

Triaged from https://github.com/whitequark/ppx_import/issues/3.

File attachments

• fix_7098.diff

[vicuna]

Comment author: @alainfrisch

Confirmed: when a ppx raises an error, it returns an empty ppx context, which resets all "cookies" used to maintain the state of ppxs.

[vicuna]

Comment author: @alainfrisch

A proposed fix is attached, in case someone needs to backport it to 4.02. It also committed to trunk ( 713447b ).