Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use in-tree ocaml/ocamlc within the manual #7146

Closed
vicuna opened this Issue Feb 11, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Feb 11, 2016

Original bug ID: 7146
Reporter: @Octachron
Assigned to: @gasche
Status: closed (set by @xavierleroy on 2017-09-24T15:32:52Z)
Resolution: fixed
Priority: low
Severity: tweak
Target version: 4.03.1+dev
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: documentation

Bug description

Currently, the manual tools and examples are build using the system ocaml
installation. This can lead to subtle bugs in the manual examples when the
system and in-tree compiler are out-of-sync: in particular, uses of newly deprecated function become harder to spot.

For the specific case of the in-manual examples, it is relatively easy to fix the problem by modifying the manual's makefiles. However, it might make sense to factorize this work with the test subtree which has already solved the very same issues.

Unfortunately, I am not sure how to do that in a portable way.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Feb 11, 2016

Comment author: @gasche

Unfortunately, I am not sure how to do that in a portable way.

I would try to split the part of testsuite/makefile/Makefile.common that sets the tool definitions into a sub-makefile testsuite/makefile/Makefile.tools, included from Makefile.common, and also from the makefiles in manual/**. The "calling convention" is to set the TOPDIR variable accordingly, and then $(OCAMLC) etc. should be usable.

I don't see portability issue with that solution.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 2, 2016

Comment author: @Octachron

Fixed by #559

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 2, 2016

Comment author: @gasche

Many thanks!

@vicuna vicuna closed this Sep 24, 2017

@vicuna vicuna added this to the 4.03.1 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.