Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows line endings breaking build #7243

Closed
vicuna opened this Issue Apr 26, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

vicuna commented Apr 26, 2016

Original bug ID: 7243
Reporter: shaynefletcher
Status: closed (set by @damiendoligez on 2016-04-28T19:22:53Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: platform support (windows, cross-compilation, etc)

Bug description

Building 4.03. I gunzip and tar xvf the source package but find that

tools/make-version-header.sh
stdlib/CompFlags

"breaks" with my Cygwin /usr/bin/sed (choking on '\r'). Problem overcome by running dos2unix on those two files.

Determined that the problem also exists (for me) with 4.02.3.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 26, 2016

Comment author: shaynefletcher

This could be a consequence of using winzip instead of (Cygwin) tar to do the unpacking. If so, probably the resolution is to simply document the issue in the README.win32.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 27, 2016

Comment author: @damiendoligez

This is definitely a consequence of using winzip, as the characters are not in the archive and don't appear when using /usr/bin/tar to unpack the archive.

We will document the problem.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 28, 2016

Comment author: @damiendoligez

Fixed in trunk (commit e55b6fd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.