Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unboxed version of operations on 64-bit integers for 32-bit ports #7246

Closed
vicuna opened this issue May 2, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented May 2, 2016

Original bug ID: 7246
Reporter: @alainfrisch
Assigned to: @diml
Status: resolved (set by @alainfrisch on 2018-11-20T11:54:50Z)
Resolution: fixed
Priority: normal
Severity: feature
Target version: 4.07.0+dev/beta2/rc1/rc2
Fixed in version: 4.08.0+dev/beta1/beta2
Category: back end (clambda to assembly)
Tags: patch
Monitored by: @gasche @diml @hcarty

Bug description

Primitive operations on 64-bit integers are turned into calls to C functions when targeting 32-bit architectures. Cf Cmmgen.simplif_primitive_32bits. We should provide unboxed non-allocating versions of these functions for the native backend.

File attachments

@vicuna

This comment has been minimized.

Copy link
Author

commented May 2, 2016

Comment author: @diml

I quickly looked at adding [@@unboxed] and [@@noalloc] for these C calls a while ago. I attached the patch I wrote, it handles +, -, * and /

@vicuna

This comment has been minimized.

Copy link
Author

commented May 2, 2016

Comment author: @alainfrisch

Did you have a reason not to apply the patch?

@vicuna

This comment has been minimized.

Copy link
Author

commented May 2, 2016

Comment author: @diml

Nope, I just wanted to finish all the primitives properly but then I ended up working on some other stuff and forgot about this

@vicuna

This comment has been minimized.

Copy link
Author

commented Feb 16, 2017

Comment author: @xavierleroy

This is a good thing to do, but it has to be done consistently. Pushing for after 4.05.

@vicuna

This comment has been minimized.

Copy link
Author

commented Nov 9, 2018

Comment author: @alainfrisch

@dim: Do you think you'll be able to resume this work?

(Personally, I wouldn't be shocked to commit a version that only deal with some of the primitives, that's already a good incremental improvement.)

@vicuna

This comment has been minimized.

Copy link
Author

commented Nov 12, 2018

Comment author: @diml

Sure, I updated the patch and added bitand, bitor and bitxor as optimised primitives: #2146

@vicuna vicuna closed this Nov 20, 2018

@vicuna vicuna added the back-end label Mar 14, 2019

@vicuna vicuna added this to the 4.07.0 milestone Mar 14, 2019

@vicuna vicuna added the feature-wish label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.