Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatten : Avoid confusion #7288

Closed
vicuna opened this issue Jul 12, 2016 · 1 comment
Closed

flatten : Avoid confusion #7288

vicuna opened this issue Jul 12, 2016 · 1 comment

Comments

@vicuna
Copy link

@vicuna vicuna commented Jul 12, 2016

Original bug ID: 7288
Reporter: tormen
Status: closed (set by @damiendoligez on 2016-09-27T14:21:19Z)
Resolution: fixed
Priority: normal
Severity: minor
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: documentation

Bug description

As Ocaml tends to be MINMAL in terms of functions in the std lib, I was a bit confused that there is List.flatten and List.concat.

This plus the fact that there was not ONLY written "Same as concat" for flatten made me wonder if they are in deed really 100% identical.

To effectively prevent such confusion I propose to simply remove the
" Not tail-recursive (length of the argument + length of the longest sub-list)."
and ONLY keep the sentence "Same as concat." :)

@vicuna
Copy link
Author

@vicuna vicuna commented Sep 27, 2016

Comment author: @damiendoligez

I've changed it to "An alias for concat." which is the terminology used elsewhere in the stdlib. (commit 5cc9300)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.