Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldoc does not support inline records #7290

Closed
vicuna opened this Issue Jul 14, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Jul 14, 2016

Original bug ID: 7290
Reporter: @gasche
Assigned to: @gasche
Status: resolved (set by @gasche on 2016-07-29T05:13:07Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.04.0 +dev / +beta1 / +beta2
Fixed in version: 4.04.0 +dev / +beta1 / +beta2
Category: ocamldoc
Has duplicate: #7410
Monitored by: @hcarty

Bug description

ocamldoc has not been updated to support inline record. This led to a manual build failure that has been fixed by octachron in #690 , but there probably still exists programs on which ocamldoc will fail with an assert failure.

octachron expressed interest in working on this.

I'm setting the target to 4.04+dev because having ocamldoc fail on existing language features may bite users down the road, so fixing this as soon as possible is preferable.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 26, 2016

Comment author: @Octachron

Expressed interest might be a tad too strong, but anyway here is a pull
request which at least fixes the remaining ocamldoc crashes and adds some basic support for documentation comments within inline records:

#720

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 29, 2016

Comment author: @gasche

Fixed by merging the proposed pull request. Thanks!

@vicuna vicuna closed this Jul 29, 2016

@vicuna vicuna added the ocamldoc label Mar 14, 2019

@vicuna vicuna added this to the 4.04.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.