Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlobjinfo : printing of "approximations" broken with flambda #7294

Closed
vicuna opened this Issue Jul 20, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Jul 20, 2016

Original bug ID: 7294
Reporter: @alainfrisch
Assigned to: @chambart
Status: closed (set by @damiendoligez on 2016-10-26T15:00:34Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Fixed in version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Category: tools (ocaml{lex,yacc,dep,debug,...})
Monitored by: @gasche

Bug description

The function Export_info.print_approx is broken, which makes the output of ocamlobjinfo for .cmx produced with flambda incomplete.

This function maintains a queue of symbols to print. The problem is that this queue is initially empty, so nothing is ever printed.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 20, 2016

Comment author: @alainfrisch

Attached a patch that seems to fix the issue, although passing the global symbol through the global reference in Compilation_unit is not very satisfactory.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 13, 2016

Comment author: @chambart

See #809

I added an additional argument to the function to avoid this. I might reconsider and directly add the root symbols to Export_info.t . But this is certainly sufficient for now. This was the case originally, and the field was removed at some point and not fixed.

@vicuna vicuna closed this Oct 26, 2016

@vicuna vicuna added the tools label Mar 14, 2019

@vicuna vicuna added this to the 4.05.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.