Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldoc should really stop generating br tags #7351

Closed
vicuna opened this issue Sep 10, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Sep 10, 2016

Original bug ID: 7351
Reporter: @dbuenzli
Assigned to: @Octachron
Status: resolved (set by @Octachron on 2017-03-15T22:06:19Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.03.0
Target version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: ocamldoc
Monitored by: @gasche @dbuenzli

Bug description

They prevent using CSS to its full extent to style the documentation. For example here's what I have in my style sheet.

br { display: none } /* Annoying, hide them. /
code br { display: block } /
Except in signatures. */

The presence of br in the output disallows me to use e + e' CSS rules. A particular instance of this in my stylesheet is:

hr
{ display: none } /* Would be nice to have but we cannot get that to
interact well with our h1's because of br markup noise */

I'd like to specify something for hr + h1 but I'm unable since the output has the sequence hr br h1

@vicuna

This comment has been minimized.

Copy link
Author

commented Sep 10, 2016

Comment author: @Octachron

I agree that most use of "br" in ocamldoc html backend are not particularly meaningful and their intend could be better expressed by more semantic tags.
I have proposed a pull request in this direction in #802.

@vicuna

This comment has been minimized.

Copy link
Author

commented Mar 15, 2017

Comment author: @Octachron

The above patch has been merged in Ocaml developpement branch, and should be integrated in OCaml 4.06.

@vicuna vicuna closed this Mar 15, 2017

@vicuna vicuna added the ocamldoc label Mar 14, 2019

@vicuna vicuna added this to the 4.05.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.