Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldoc sometimes generates untagged text #7353

Closed
vicuna opened this issue Sep 10, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Sep 10, 2016

Original bug ID: 7353
Reporter: @dbuenzli
Assigned to: @Octachron
Status: resolved (set by @Octachron on 2017-03-15T22:12:23Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.03.0
Target version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: ocamldoc
Monitored by: @gasche @dbuenzli

Bug description

Here's an example:

The text "Besides ..." that follows the first code fence of this section:

http://erratique.ch/tmp/opkg-ocamldoc/var/cache/opkg/ocamldoc/react/React.html#lifting

Is not wrapped into a p as would be expected. Here's the code:

https://github.com/dbuenzli/react/blob/master/src/react.mli#L949-L957

@vicuna

This comment has been minimized.

Copy link
Author

commented Sep 11, 2016

Comment author: @Octachron

The untagged text elements in this example stems from the fact that ocamldoc
only emits opening "p" tags at newline (and never closes them), so whenever browsers automatically close the tag at the end of a phrasing content, the next text element is never wrapped in a "p" tag.

To solve this problem, I have proposed to make the generation of paragraph element by ocamldoc much more regular in #804.

@vicuna

This comment has been minimized.

Copy link
Author

commented Mar 15, 2017

Comment author: @Octachron

The above PR have integrated into the current development version and this is issue is on its way to be fixed in Ocaml 4.06.

@vicuna vicuna closed this Mar 15, 2017

@vicuna vicuna added the ocamldoc label Mar 14, 2019

@vicuna vicuna added this to the 4.05.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.