Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml.warning does not work with ocaml.ppwarning #7361

Closed
vicuna opened this issue Sep 17, 2016 · 2 comments
Closed

ocaml.warning does not work with ocaml.ppwarning #7361

vicuna opened this issue Sep 17, 2016 · 2 comments
Assignees
Milestone

Comments

@vicuna
Copy link

@vicuna vicuna commented Sep 17, 2016

Original bug ID: 7361
Reporter: @bobzhang
Assigned to: @alainfrisch
Status: resolved (set by @alainfrisch on 2017-10-10T09:33:23Z)
Resolution: fixed
Priority: normal
Severity: minor
Target version: 4.06.0 +dev/beta1/beta2/rc1
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: compiler driver
Related to: #6714
Monitored by: @gasche

Bug description

[@@@ocaml.warning "-22"]

let a = 3
[@@ocaml.ppwarning "hey"]

ocamlc.opt -c a.ml // print warning which should not
ocamlc.opt -w -22 -c a.ml // good

@vicuna

This comment has been minimized.

Copy link
Author

@vicuna vicuna commented Sep 17, 2016

Comment author: @bobzhang

relevant issue #6714, I feel that it is very hard to get a solid implementation for @@@ocaml.warning, @@ocaml.waring and @ocaml.warning.

Maybe the most simple and solid implementation is just allow @@@ocaml.warning in the beginning of a file

@vicuna

This comment has been minimized.

Copy link
Author

@vicuna vicuna commented Jul 19, 2017

Comment author: @alainfrisch

Will be fixed by : #1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.