Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing assert failure with nonrec priv #7437

Closed
vicuna opened this issue Dec 21, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Dec 21, 2016

Original bug ID: 7437
Reporter: @avsm
Assigned to: @garrigue
Status: resolved (set by @garrigue on 2016-12-26T07:57:37Z)
Resolution: fixed
Priority: normal
Severity: crash
Version: 4.04.0
Fixed in version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Category: typing
Monitored by: @gasche

Bug description

type t = [` Closed ];;
type nonrec t = private [> t];;

Running this through "ocaml foo.ml" on 4.04.0:

Fatal error: exception File "typing/typedecl.ml", line 454, characters 26-32: Assertion failed

No exception with "ocamlc -i":

ocamlc -i t.ml
File "t.ml", line 2, characters 12-13:
Error: Multiple definition of the type name t.
Names must be unique in a given structure or signature

Additional information

Found by Thomas Gazagnaire during mirage/mirage#743

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 26, 2016

Comment author: @garrigue

Fixed by commit 94a1f38.
Private rows should be added to the environment, even in the nonrec case (they are needed, and they cannot be accessed from the syntax anyway).

@vicuna vicuna closed this Dec 26, 2016

@vicuna vicuna added the typing label Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.