Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unboxed type with unboxed argument should not be accepted #7511

Closed
vicuna opened this Issue Mar 28, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Mar 28, 2017

Original bug ID: 7511
Reporter: @yallop
Assigned to: @damiendoligez
Status: resolved (set by @damiendoligez on 2017-06-22T09:23:47Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Target version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Fixed in version: 4.05.0 +dev/beta1/beta2/beta3/rc1
Category: typing

Bug description

$ cat ub.ml
type _ s = S : 'a -> 'a s [@@unboxed]
type t = T : _ s -> t [@@unboxed]
let _ = [| T (S 0.0); T (S 0) |]

$ ocaml ub.ml
Segmentation fault

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 3, 2017

Comment author: @damiendoligez

see #1133: #1133

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 5, 2017

Comment author: @chambart

I would argue that the problematic type is 's' rather than 't' in this example.

It is the one that doesn't always have the same representation.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 6, 2017

Comment author: @lpw25

I would argue the problematic type is 'float array'. :)

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Apr 10, 2017

Comment author: @damiendoligez

This is a bit more subtle than I thought, so I'm pushing the target version back to 4.05.0.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jun 22, 2017

Comment author: @damiendoligez

fixed by #1133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.