List.compare_length_with mishandles negative numbers / overflow #7513

vicuna · 2017-04-04T13:48:18Z

Original bug ID: 7513
Reporter: @yallop
Assigned to: @lefessan
Status: resolved (set by @mshinwell on 2017-05-16T20:00:26Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: standard library

Bug description

List.compare_length_with [] min_int;;

: int = 1

List.compare_length_with [1] min_int;;

: int = -1

vicuna · 2017-04-05T08:21:05Z

Comment author: @lefessan

I submitted the following PR:
#1136

You might want to review it to check that it does not introduce another bug.

vicuna · 2017-05-16T20:00:10Z

Comment author: @mshinwell

#1136 has been merged to fix this issue.

Add tests List.compare_lengths and List.compare_length_with in tests/lib-list

vicuna closed this as completed May 16, 2017

vicuna added the stdlib label Mar 14, 2019

vicuna assigned lefessan Mar 14, 2019

vicuna added the bug label Mar 20, 2019

lefessan added a commit to lefessan/ocaml that referenced this issue Jun 22, 2020

Fix bug ocaml#7513

caf3f1c

Add tests List.compare_lengths and List.compare_length_with in tests/lib-list

List.compare_length_with mishandles negative numbers / overflow #7513

List.compare_length_with mishandles negative numbers / overflow #7513

vicuna commented Apr 4, 2017

vicuna commented Apr 5, 2017

vicuna commented May 16, 2017

List.compare_length_with mishandles negative numbers / overflow #7513

List.compare_length_with mishandles negative numbers / overflow #7513

Comments

vicuna commented Apr 4, 2017

Bug description

List.compare_length_with [] min_int;;

List.compare_length_with [1] min_int;;

vicuna commented Apr 5, 2017

vicuna commented May 16, 2017