Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel builds are broken in the ocamldoc/ subdirectory [was: lex/ directory] #7587

Closed
vicuna opened this Issue Jul 17, 2017 · 6 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Jul 17, 2017

Original bug ID: 7587
Reporter: Richard Jones
Assigned to: @shindere
Status: resolved (set by @xavierleroy on 2017-09-21T15:15:04Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: x86_64
OS: Linux
OS Version: Fedora 27
Version: 4.05.0
Target version: 4.06.0 +dev/beta1/beta2/rc1
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: configure and build/install
Monitored by: @gasche

Bug description

Parallel builds (make -j 16) are broken in the lex/ subdirectory. See the attached build log.

Steps to reproduce

make -j 16 world.opt

Additional information

This working (perhaps by luck) in OCaml 4.04.x.

File attachments

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 17, 2017

Comment author: Richard Jones

I should have said the obvious workaround (make -j1) works.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 17, 2017

Comment author: @gasche

Thanks for the report.

I have the impression from your log that the issue is actually in ocamldoc/ rather than lex/. There were various changes to the ocamldoc build system recently.

What is the way you rely on parallel builds / how can a fix reach you? If the issue exists with the 4.05.0 release but is fixed in the 4.05 branch, is it good for you? If it exists in 4.05 but is fixed in trunk, is that an issue?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 17, 2017

Comment author: @shindere

It seems this is an ocamldoc dependency issue that has nothing to do with the lex directory.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 17, 2017

Comment author: Richard Jones

Yes, looking more closely at the log I think you are correct that the problem lies in ocamldoc.

We can cherry-pick fixes for Fedora from anywhere. We have a downstream repo containing various changes on top of (currently) 4.05 which we ship to Fedora end-users and RHEL customers.

https://pagure.io/fedora-ocaml/branch/fedora-27-4.05.0

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 21, 2017

Comment author: @xavierleroy

I can reproduce the "make -j16" problem in ocamlopt with 4.05 but not with 4.06 after many runs. The problem in 4.05, as far as I can see, is the lack of dependencies for the "generators/*.cmxs" targets. Those were added by commits d377bce (fixes the Makefile) then f6736c1 (updates the .depend).

@vicuna vicuna closed this Sep 21, 2017

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 21, 2017

Comment author: Richard Jones

OK let's mark this as fixed in that case. I will try 4.06 when it's released.

@vicuna vicuna added this to the 4.06.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.