Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacs mode uses variable that has been removed from Emacs 25 #7610

Closed
vicuna opened this Issue Aug 20, 2017 · 2 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

commented Aug 20, 2017

Original bug ID: 7610
Reporter: sebmondet
Status: resolved (set by @xavierleroy on 2017-09-30T14:26:50Z)
Resolution: fixed
Priority: normal
Severity: minor
OS: Emacs 25
Target version: 4.06.0 +dev/beta1/beta2/rc1
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: emacs mode

Bug description

The last-command-char variable does not exist any more in Emacs ? 25.

It's used in caml-abbrev-hook:
https://github.com/ocaml/ocaml/blob/trunk/emacs/caml.el#L1767

See also https://emacs.stackexchange.com/questions/27920/symbol-s-value-as-variable-is-void-last-command-char-when-trying-to-insert-brac

Steps to reproduce

Type a keyword like in and then an Emacs command.

Additional information

Bypassed the problem with:

(defun caml-abbrev-hook () (progn (message "abbrev-caml")))
@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 21, 2017

Comment author: @psteckler

`last-command-char' isn't in 24.5, either.

In older Emacs version, it appears to have been a synonym for `last-command-event', which is still present in Emacs 25.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 30, 2017

Comment author: @xavierleroy

Thanks @psteckler for the suggested fix and Stefan Monnier for confirming it. last-comment-event it is. [trunk 16efe10] [4.06 341a1e7]

@vicuna vicuna closed this Sep 30, 2017

@vicuna vicuna added the emacs-mode label Mar 14, 2019

@vicuna vicuna added this to the 4.06.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.