Skip to content

Manual's description of refutation cases is unclear #7613

Closed

Description

@vicuna

Original bug ID: 7613
Reporter: coventry
Assigned to: @Octachron
Status: resolved (set by @Octachron on 2018-04-01T14:04:53Z)
Resolution: fixed
Priority: low
Severity: minor
Fixed in version: 4.07.0+dev/beta2/rc1/rc2
Category: documentation

Bug description

Currently this section: https://caml.inria.fr/pub/docs/manual-ocaml/extn.html#sec241

The "and redundancy" in the title makes it sound like refutation cases are something defined elsewhere, and have some relationship to GADTs via redundancy. The fact that redundancy isn't mentioned anywhere in the section is also confusing -- I think it means branches of a pattern match which are redundant due to being untypable. "which are both untypable" would be clarified by adding "because deep expects a [char t]".

My confusion was cleared up by https://discuss.ocaml.org/t/matching-incompatible-gadt-constructors/682 , FWIW. I think it's much clearer.

Activity

  1. vicuna commented on Mar 24, 2018

    @vicuna
    Author

    Comment author: @Octachron

    Your suggestions have been implemented in #1677 . Do you wish to appear in the change entry? (and if yes, under which name or pseudonym?)

  2. vicuna commented on Mar 28, 2018

    @vicuna
    Author

    Comment author: coventry

    Thanks, Florian. It's fine as is.

    Best regards,
    Alex

  3. vicuna commented on Apr 1, 2018

    @vicuna
    Author

    Comment author: @Octachron

    The PR above was merged, the manual will be updated with the fixes once 4.07 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions