Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.06.0 Change : Format change must be marked as breaking. #7627

Closed
vicuna opened this Issue Sep 15, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Sep 15, 2017

Original bug ID: 7627
Reporter: furuse
Assigned to: @lpw25
Status: resolved (set by @gasche on 2017-09-15T09:16:35Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.05.0
Target version: 4.06.0 +dev/beta1/beta2/rc1
Fixed in version: 4.06.0 +dev/beta1/beta2/rc1
Category: documentation

Bug description

  • Resurrect tabulation boxes in module Format. Rewrite/extend documentation
    of tabulation boxes.

This changes the signature of Format and several applications which improve Format by themselves such as spotlib and omake fail to compile in 4.06.0+trunk.

The changes themselves are ok but please mark it as a breaking change.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 15, 2017

Comment author: @gasche

So the problem is that the commit

c9cc0f2

removed the pp_* versions of the tabulation boxes functions.

I don't understand why this was done, we need to ask the format maintainers. Maybe it is possible to restore these functions to restore compatibility.

(Octachron noticed this in #1291 but he was too shy to complain about it.)

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 15, 2017

Comment author: @lpw25

I already asked the maintainers on the devel list. It was an accident. I'm making a pull request to put them back now.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 15, 2017

Comment author: @lpw25

#1337

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 15, 2017

Comment author: @gasche

Fixed by Leo in the PR above.

@vicuna vicuna closed this Sep 15, 2017

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Sep 15, 2017

Comment author: furuse

Thanks. Please note that I am also too shy to complain about the change made by my thesis advisor.

@vicuna vicuna added this to the 4.06.0 milestone Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.