Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowing standard library modules doesn't work in the toplevel #7841

Closed
vicuna opened this issue Aug 22, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@vicuna
Copy link

commented Aug 22, 2018

Original bug ID: 7841
Reporter: @dra27
Assigned to: @diml
Status: assigned (set by @dra27 on 2018-08-22T14:35:19Z)
Resolution: open
Priority: high
Severity: minor
Platform: any
OS: n/a
OS Version: n/a
Version: 4.07.0
Target version: 4.08.0+dev/beta1/beta2
Category: toplevel
Monitored by: @nojb

Bug description

Shadowing standard library modules doesn't work in the toplevel, in particular the new Result module merged in 4.08 shadows the opam result package's Result module.

Steps to reproduce

The result should be a module with a single type, but the standard library's Result module will be shown instead.

Additional information

See comments at the end of #1956 (#1956 (comment))

@vicuna

This comment has been minimized.

Copy link
Author

commented Aug 22, 2018

Comment author: @xavierleroy

EDIT: I posted a wrong comment before, please ignore.

@vicuna

This comment has been minimized.

Copy link
Author

commented Sep 19, 2018

Comment author: @diml

This is fixed by this PR: #2041

@vicuna vicuna added this to the 4.08.0 milestone Mar 14, 2019

@dbuenzli

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

This issue can be closed.

@nojb

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Thanks!

@nojb nojb closed this Mar 15, 2019

@vicuna vicuna added the bug label Mar 20, 2019

@nojb nojb modified the milestones: 4.08.0, 4.08 Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.