Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_multi_byte_to_wide_char should use CP_ACP instead of CP_THREAD_ACP #7854

Closed
vicuna opened this issue Sep 24, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link

commented Sep 24, 2018

Original bug ID: 7854
Reporter: turpin
Assigned to: @nojb
Status: resolved (set by @nojb on 2018-12-02T15:10:44Z)
Resolution: fixed
Priority: normal
Severity: minor
Platform: Windows MSVC
OS: Windows MSVC
OS Version: Windows 10
Fixed in version: 4.08.0+dev/beta1/beta2
Category: platform support (windows, cross-compilation, etc)

Bug description

I believe that, for the intended backward-compatibility purpose, CP_ACP is more appropriate than CP_THREAD_ACP. The former (System active code page) is the one used by the ANSI version of the Windows API functions. I think the latter is more related to user language settings.

Steps to reproduce

Difference between CP_THREAD_ACP and CP_ACP was observed on a japanese Windows 10 host (shift_js) with french as use language setting.

@vicuna

This comment has been minimized.

Copy link
Author

commented Sep 24, 2018

Comment author: @nojb

Indeed, this looks like a bug. Some more information here: https://lists.boost.org/Archives/boost/2010/11/173382.php

@vicuna

This comment has been minimized.

Copy link
Author

commented Sep 24, 2018

Comment author: @nojb

#2062

@vicuna

This comment has been minimized.

Copy link
Author

commented Dec 2, 2018

Comment author: @nojb

Merged, will be in 4.08

@vicuna vicuna closed this Dec 2, 2018

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.