Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TypedtreeIter by Tast_iterator #7878

Closed
vicuna opened this issue Nov 29, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@vicuna
Copy link

commented Nov 29, 2018

Original bug ID: 7878
Reporter: @trefis
Status: acknowledged (set by @gasche on 2019-02-20T15:37:21Z)
Resolution: open
Priority: low
Severity: minor
Category: misc
Tags: junior_job
Monitored by: @nojb

Bug description

And make it consistent with Ast_iterator.

Cf. #2173

@vicuna vicuna added the junior-job label Mar 14, 2019

@ILikePizza555

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Hi!

I'd like to pickup this issue for the outreachy internship. Any advice or recommendations anyone would like to share?

@vicuna vicuna added the bug label Mar 20, 2019

@ILikePizza555

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

I guess I should ask @gasche for assistance, right?

I'm obviously rather new to OCaml, but I have worked with ASTs before. Do you think that this is something that can be done within the current timeframe? Or should I consider another issue?

@trefis trefis removed the bug label Mar 20, 2019

@trefis

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2019

I don't know what the timeframe is, but this seems doable in a short period of time.
Basically what you want to do is this:

  • create typing/tast_iterator.ml[i], that is related to typing/tast_mapper.ml[i] in the same way parsing/ast_iterator.ml[i] is related to parsing/ast_mapper.ml[i].
    (I suggest you diff parsing/ast_mapper.mli with parsing/ast_iterator.mli and typing/tast_mapper.mli)
  • git rm typing/typedtreeIter.ml typing/typedtreeIter.mli
  • replace the uses (I think there's only one) of TypedtreeIter that don't compile anymore, with uses of your new Tast_iterator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.