Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Tsubst remaining in structure after call to Env.save_signature #7929
Original bug ID: 7929
Noticed when trying odoc on 4.08: ocaml/odoc#311
The regression is due to: 4d4fd52#diff-668ada709c086c9f2b56861bb1872a5dR461
It made the assumption that the order in which we apply the substitution doesn't matter.
The obvious fix is to replace the call to List.rev_map by List.rev followed by List.map.
Another potential option would be to introduce functions like class_declaration' (and others) which don't do the cleanup.
I'm going to experiment with that (unless someone jumps in to explain why it can't possibly be correct) and if it works I'll submit that as a fix instead of the obvious one.