Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pa_macro: use ENDIF instead of (in addition to) END #8344

Closed
vicuna opened this Issue Oct 29, 2003 · 3 comments

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

vicuna commented Oct 29, 2003

Original bug ID: 1901
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: feature
Category: ~DO NOT USE (was: OCaml general)

Bug description

Full_Name: Aleksey Nogin
Version: 3.07pl2
OS: Red Hat Linux
Submission from: charter-182-203.caltech.edu (131.215.182.203)

The new pa_macro package uses "IFDEF ... THEN ... END", but IMHO it would be
more natural to use the "ENDIF" instead of "END" (or at least allow "ENDIF" as
an alternative to "END").

A trivial patch is at http://nogin.org/patches/ocaml-3.07-macro-endif.patch

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jun 29, 2004

Comment author: administrator

Granted. ENDIF and END are both accepted for closing IFDEF et al.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 8, 2004

Comment author: administrator

Dear Aleksey,

I also have extended pa_macro according to most of your wishes (#2569[1245])
excepted for the following:

I understand why you need them, and appreciate your contribution, but I need
some time to think about the design of this macro language. So, local and
NOTHING macros won't be part of the 3.08 release.

Thanks,

-- Michel

@vicuna vicuna closed this Jul 8, 2004

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jul 8, 2004

Comment author: administrator

On 08.07.2004 02:03, Michel Mauny wrote:

I also have extended pa_macro according to most of your wishes (#2569[1245])

Thank you!

excepted for the following:

I understand why you need them, and appreciate your contribution, but I need
some time to think about the design of this macro language.

I understand. Please let me know if you want some feedback and/or help
with any of this stuff.

So, local and NOTHING macros won't be part of the 3.08 release.

OK, I'll try to keep the remaining patches up-to-date once 3.08 is
released so that I can keep using these features locally and I will make
them available in case you decide to include them after all.

--
Aleksey Nogin

Home Page: http://nogin.org/
E-Mail: nogin@cs.caltech.edu (office), aleksey@nogin.org (personal)
Office: Jorgensen 70, tel: (626) 395-2907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.