Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] pa_macro: allow multiple macro declarations in IFDEF branches #8347

Closed
vicuna opened this Issue Oct 29, 2003 · 1 comment

Comments

Projects
None yet
1 participant
@vicuna
Copy link
Collaborator

vicuna commented Oct 29, 2003

Original bug ID: 1904
Reporter: administrator
Status: closed
Resolution: fixed
Priority: normal
Severity: feature
Category: ~DO NOT USE (was: OCaml general)

Bug description

Full_Name: Aleksey Nogin
Version: 3.07pl2
OS: Red Hat Linux
Submission from: mojave1.cs.caltech.edu (131.215.44.186)

Currently pa_macro only allows a single macro declaration or a list of str_item
in a branch of a top-level IFDEF. Multiple macro declarations and/or mixing
declaratins with ordinary str_items are not supported. If would be nice to get
rid of this limitation.

I wrote a patch that accomplishes this -
http://nogin.org/patches/ocaml-3.07-macro-multdecls.patch

Note that the above patch is supposed to go on top of two other pa_macro patches
I've submitted (#1901 and #1902). The end result is also available on our CVS -
please see http://cvs.metaprl.org:12000/cvsweb/metaprl/util/Attic/pa_macro.ml?only_with_tag=ocaml_3_07

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Jun 29, 2004

Comment author: administrator

Done. MM, 2004-06-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.