Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldep -allow-approx turns errors into successes #8635

Closed
diml opened this issue Apr 23, 2019 · 0 comments

Comments

@diml
Copy link
Member

commented Apr 23, 2019

When using -allow-approx, ocamldep might turns errors into successes as soon as a file doesn't parse. For instance:

$ ocamldep -allow-approx -I /toto x.ml
Bad -I option: /toto: No such file or directory
x.cmo :
x.cmx :
$ echo $?
2
$ ocamldep -allow-approx -I /toto x.ml file_that_doesnt_parse.ml 
Bad -I option: /toto: No such file or directory
File "file_that_doesnt_parse.ml", line 2, characters 0-0:
Error: Syntax error
file_that_doesnt_parse.cmo :
file_that_doesnt_parse.cmx :
x.cmo :
x.cmx :
$ echo $?
0
@diml diml self-assigned this Apr 23, 2019
@diml diml added the bug label Apr 23, 2019
diml added a commit to diml/ocaml that referenced this issue Apr 23, 2019
diml added a commit to diml/ocaml that referenced this issue Apr 23, 2019
@diml diml closed this in 1f026fd Apr 23, 2019
smuenzel added a commit to smuenzel/ocaml that referenced this issue Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.