Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible (latent) bug in Ctype.normalize_type #8792

Open
alainfrisch opened this issue Jul 4, 2019 · 0 comments

Comments

@alainfrisch
Copy link
Contributor

commented Jul 4, 2019

The following line seems suspicious:

log_type ty; fi.desc <- fi'.desc

I would expect that fi, not ty should be logged, since it is the one whose desc field is modified.

What about turning the log_type function into logged_set_desc, which does both the logging and setting the desc field?

(Introduced in commit 65c80f8)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.