Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bespoke typedefs in the C runtime #8916

Open
jflopezfernandez opened this issue Sep 4, 2019 · 1 comment

Comments

@jflopezfernandez
Copy link

commented Sep 4, 2019

Is there a reason for typedefs like typedef size_t asize_t? I can see the logic in using a typedef for caml_stat_block to indicate that memory must come only from caml_stat_* functions as opposed to another memory manager, but I feel like using a typedef like typedef char* addr just makes the take longer to understand because you have to figure out if 'addr' is a void*, char*, ptrdiff_t, unsigned long, etc. What is the project's stance on these data types? Would pull reviews refactoring some of these data types like asize_t to size_t be considered?

@dra27

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

For addr, see #8896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.