Harden descriptor_is_in_binary_mode #9892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierleroy
approved these changes
Sep 8, 2020
|
I'm not sure the contribution counts relative to the rest of the PR! Git will, as it were, blame me if necessary in future... |
|
Git never forgets! Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while post-reviewing #9872 - the new
descriptor_is_in_binary_modecontains a check which used to be incaml_channel_binary_mode. While it was almost certainly correct when the function was originally written in the nineties, extra modes were added in the version 7 CRT (.NET 2002). They're not compatible with the OCaml runtime, but it doesn't feel correct the querying an fd should actually change its properties. This simply tweaks the check restore the mode which was returned instead.