Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up and fix GC message 0x1 #9949

Merged
merged 2 commits into from Oct 9, 2020
Merged

clean up and fix GC message 0x1 #9949

merged 2 commits into from Oct 9, 2020

Conversation

damiendoligez
Copy link
Member

GC message number 1 is displayed at the start of major collections (as advertised in the docs) but also in some cases when caml_finish_major_cycle is called. caml_finish_major_cycle is important because it is a major source of latency. This PR:

  1. documents the fact that GC message 1 is also displayed when finishing a major cycle
  2. makes sure the message is always displayed when finishing a major cycle.

@damiendoligez
Copy link
Member Author

cc @lpw25

xavierleroy
xavierleroy approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@xavierleroy xavierleroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who could object to more precise GC messages?

@damiendoligez damiendoligez merged commit 0069123 into ocaml:trunk Oct 9, 2020
@damiendoligez damiendoligez deleted the fix-gc-message-1 branch October 9, 2020 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavierleroy xavierleroy xavierleroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@damiendoligez @xavierleroy