Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix parsing of OCaml code by ocamlyacc #1012
Thanks for the patch - a few things, though, please. There are various things which look unrelated to the two PRs (sorry if I'm misreading the code) - this single commit seems to combine some tidying, some necessary refactoring and fixing two PRs. I think I'm correct that fixing the actual code changes for the two PRs are not directly related, so please could you split it into four commits to create a slightly more bisect-able story:
Please also do a Changes entry (again, these aren't related so it should be really be two entries - it's fine fixing in one pull request, of course) and if you could bear to turn the two sample files you sent into testsuite tests, that would be great (I can do that afterwards if you don't have time/inclination).
The %ident and %union directives don't make sense for OCaml, and generated broken OCaml code. Just drop support for them.
The processing of apostrophes, quoted strings and comments was duplicated in at least two places. This refactors both into functions. Also move the bitmap code, for use by later changes.
This adds a partial testcase for the better lexing of OCaml code by ocamlyacc, as well as a bug fix.
On Jul 12, 2017 10:45 AM, "Gabriel Scherer" ***@***.***> wrote: In the Changes file, this change is marked as compatibility-breaking (use of the * bullet instead of -). @DemiMarie <https://github.com/demimarie>, how does it break compatibility (besides fixing wrong behaviors)? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1012 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGGWB8Y9Fev7MKIFneVpkSE9UfSrMc5Jks5sNNvhgaJpZM4LjzmX> .