New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing of missing set of closures bug #1019

Merged
merged 6 commits into from Feb 15, 2017

Conversation

Projects
None yet
2 participants
@chambart
Contributor

chambart commented Jan 25, 2017

A crash occured when rebuilding an approximation of a set of closure from another compilation unit which was not loaded (either missing, or a dependency was missing).

This contains 3 fixes:

  • Allow building an 'Unresolved' approximation for such a function (to handle the missing cmx files)
  • Ensures a reference to a set of closures loads the origin cmx file (if available)
  • Substitutes set_of_closures_id when building a pack

The pack part is needed as set_of_closures_id are used to find the file containing a set_of_closures.

This should probably also go into 4.04.1. The problem was uncovered while building the next version of core on 4.03

@chambart chambart added the bug label Jan 25, 2017

@chambart chambart added this to the 4.04.1 milestone Jan 25, 2017

@mshinwell

This comment has been minimized.

Show comment
Hide comment
@mshinwell

mshinwell Feb 15, 2017

Contributor

This important fix has been read by @lpw25 and myself and is OK. We should backport this to 4.04.1.

Contributor

mshinwell commented Feb 15, 2017

This important fix has been read by @lpw25 and myself and is OK. We should backport this to 4.04.1.

@mshinwell mshinwell merged commit e1980b3 into ocaml:trunk Feb 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

damiendoligez added a commit that referenced this pull request Apr 7, 2017

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment