Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MPR #7501: stack overflow on uunf with flambda #1089

Merged
merged 3 commits into from Apr 10, 2017

Conversation

Projects
None yet
5 participants
@chambart
Copy link
Contributor

commented Mar 8, 2017

This makes arrays of length 0 to be considered as constants, allowing them to be symbols.
This reduces a lot the code size on the failing file, hence preventing the stack overflow.
https://caml.inria.fr/mantis/view.php?id=7501

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2017

@lpw25 should look at this.

@mshinwell mshinwell requested a review from lpw25 Mar 10, 2017

@mshinwell mshinwell added the bug label Mar 10, 2017

@lpw25

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

Looks right to me

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2017

OK

@mshinwell mshinwell added the approved label Mar 15, 2017

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Mar 16, 2017

@chambart This needs a Changes entry

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

Should this be considered for 4.05 and 4.04.1?

@gasche

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

I would at least merge in 4.05 as well -- it is arguably a bugfix and it seems low-risk enough.

@damiendoligez damiendoligez added this to the 4.04.1 milestone Apr 3, 2017

@damiendoligez

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

@chambart could you add a Changes entry, then we'll merge and cherry-pick to 4.04 and 4.05.

@mshinwell

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2017

I added the Changes entry on @chambart 's branch. I will merge to trunk and cherry-pick to 4.04.

@mshinwell mshinwell merged commit 617f94f into ocaml:trunk Apr 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.