Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use OCAML_COLOR environment variable for deciding whether to use colors in output #1098
Since 4.03, OCaml supports coloring its messages to standard output and standard
The user should have control over coloring (or not) OCamls output messages. A
An extensive discussion where the solution implemented here was proposed is
I'd consider this as a minor bugfix which enables proper coloring, and would be glad if included in the 4.05 release.
This was referenced
Mar 11, 2017
I could agree in principle with having a feature in 4.05. Some remarks:
@gasche thanks for your quick feedback.
I fixed your first and second remark in 7db01ef.
Yes, I think duplicating in
@dbuenzli would you by chance be willing to give an opinion on the proposed UI?
I like the new version. I find the explicit call to
Compmisc.read_color_env right after
Clflags.parse_arguments a bit irritating (it feels like breaking some abstraction convention), but I don't see a better way to do it right now -- I think that if more options start doing this we could see a pattern emerge for a more abstract/general construction.