New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR#7504: fix warning 8 with unconstrained records #1106

Merged
merged 1 commit into from Mar 14, 2017

Conversation

Projects
None yet
2 participants
@Octachron
Contributor

Octachron commented Mar 14, 2017

Mantis#7504:

WIthout this fix, the exhaustiveness check for

let f = function {contents=_}, 0 -> 0;;

yields an invalid pattern in the warning message

Warning 8: this pattern-matching is not exhaustive.
Here is an example of a case that is not matched:
({}, 1)

due to a mishandled case when there is no constraint on any field of a record in a counter-example.

This fix correct this warning message to

Warning 8: this pattern-matching is not exhaustive.
Here is an example of a case that is not matched:
(_, 1)
@gasche

gasche approved these changes Mar 14, 2017

You need a Changes entry.

@gasche gasche merged commit 910287e into ocaml:4.05 Mar 14, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gasche

This comment has been minimized.

Member

gasche commented Mar 14, 2017

Merged in 4.05, cherry-picked in trunk ( a662a64 ).

camlspotter pushed a commit to camlspotter/ocaml that referenced this pull request Oct 17, 2017

Merge pull request ocaml#1106 from Octachron/pr7504_fix
PR#7504: fix warning 8 with unconstrained records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment