Skip to content

Avoid an unused-variable warning when POSIX_SIGNALS is not defined#11606

Merged
Octachron merged 1 commit intoocaml:trunkfrom
kit-ty-kate:no-posix-signals-warnings
Oct 6, 2022
Merged

Avoid an unused-variable warning when POSIX_SIGNALS is not defined#11606
Octachron merged 1 commit intoocaml:trunkfrom
kit-ty-kate:no-posix-signals-warnings

Conversation

@kit-ty-kate
Copy link
Copy Markdown
Member

Encountered this when porting ocaml-solo5 to OCaml 5, which compiles the OCaml runtime using -Werror

Copy link
Copy Markdown
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly correct. I think this should be backported into 5.0 as well.

@Octachron Octachron merged commit 1c1e441 into ocaml:trunk Oct 6, 2022
Octachron added a commit that referenced this pull request Oct 6, 2022
Avoid an unused-variable warning when POSIX_SIGNALS is not defined

(cherry picked from commit 1c1e441)
@kit-ty-kate kit-ty-kate deleted the no-posix-signals-warnings branch October 13, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants