-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix 'caml_unregister_frametable(table)' when 'table' is the first element #11636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ekdohibs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct to me!
|
@Ekdohibs thanks! Do you know if this bug also requires a fix in 5.0? (cc @Octachron: I'm happy to approve on @Ekdohibs' behalf, but can we include new fixes in 4.14 now that a RC is out?) |
|
We are indeed lacking a development branch for 4.14 right now. It would be better to merge the PR after the 4.14.1 release in less than two weeks. Then the fix will be part of the 4.14.2 release. |
|
(If there is something to fix in trunk, possibly by just rebasing the proposed patch, we can merge it right now; ideally someone would do a separate PR for this.) |
|
I'm not sure if there are any changes to do in trunk, since the logic for freeing frame descriptors changed quite a lot: ocaml/runtime/frame_descriptors.c Lines 195 to 208 in b06f2d1
|
nojb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a Changes entry I think.
fe8c9a9 to
fe0ddc9
Compare
Closes #11633.