Split Typecore.unify_pat_types into two to avoid unnecessary references to the environment in type_pat
#12025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
(Assigning @trefis with his approval, under the new semantics of "person in charge of making that the PR is making progress" (not necessarily making the work themselves).) |
t6s
force-pushed
the
unify_pat_types_refine
branch
2 times, most recently
from
45ce886 to
f9f1af7
Compare
gasche
approved these changes
May 22, 2023
Member
gasche
left a comment
gasche
left a comment
There was a problem hiding this comment.
Approved. I only made a superficial review (the underlying reason why we needed a reference here is quite subtle and I don't claim to master it), but clearly this is only changing the type-checker in very subtle ways and the testsuite still passes.
t6s
force-pushed
the
unify_pat_types_refine
branch
from
f9f1af7 to
5b37f49
Compare
Contributor
Author
|
@gasche Thank you so much for the review. I have rebased and updated the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typecore.unify_pat_typeshas two different use-cases: one intype_patthat does not update the environment, and the other incheck_counter_example_patthat needs arefineargument and updates the environment.This PR splits these into two different functions and eliminates the updates to the environment from most parts of
type_pat.This PR subsumes #12020 .