New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move complugin and friends from BYTECOMP to COMP #1216
Conversation
The way |
This may need looking at in conjunction with #1063, which changes some of the dynlink source files around a bit. |
Are you suggesting moving |
@gasche Could you clarify what you would like to be done differently? (or if you're happy with it approve it for merge) |
On my first (incompelte) read, I thought that "only compplugin" had moved. I understand that its dependencies had to be moved as well, but I am uncomfortable with the fact that some dependencies that look "very bytecode" to me ( My remark in the previous comment can be explicited: if I understand correctly, there are two implementations of compplugin, and only the bytecode one needs |
The point is that some of the files in the This patch also fixes a regression if I understand correctly. This is OK subject to the tests passing. |
Co-authored-by: cuihtlauac <cuihtlauac@users.noreply.github.com>
This moves
Complugin
and its dependencies from theBYTECOMP
Makefile section to theCOMP
Makefile section because they are used by parts of ocamlopt. In particular, without this changeocamlopttoplevel.cmxa
cannot be linked withoutocamlbytecomp.cmxa
-- which is a regression from 4.03.0.