fix invalid_argument on some external or module aliases in ocamlnat #12260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do you think you could rewrite this part of the code to use |
Contributor
Author
|
@lthls Good idea, done. |
lthls
approved these changes
May 24, 2023
Contributor
lthls
left a comment
lthls
left a comment
There was a problem hiding this comment.
I'm fine with the current version. We could add an extra sanity check that the number of runtime components in the signature (List.length exported) is equal to the size of the module block if we feel extra cautious, but if it's not we're likely going to find out immediately in a slightly less friendly way anyway.
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12257.
As suspected in #12257 (comment), module aliases also trigger the problem. I'm not too familiar with the module representation, so it would be good if an flambda dev could have a closer look to see if any other constructs could trigger the problem.