In C++, give Bool_val the type bool
#12702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
approved these changes
Oct 30, 2023
Member
gasche
left a comment
gasche
left a comment
There was a problem hiding this comment.
I agree that it does what it says on the tin.
C++ 11 prohibits narrowing conversions from `int` to `bool` in some contexts (list initialization). C has no `bool` type by default, only `_Bool`, which is not in C++ by default. So we end up with two definitions of `Bool_val`, one for C and one for C++. Fixes: ocaml#11332
Contributor
Author
|
Should this be backported to 4.12 LTS ? |
Member
|
This seems worth it to maintain compatibility between 4.14 LTS and OCaml 5 for the FFI headers. |
xavierleroy
added a commit
that referenced
this pull request
Oct 30, 2023
C++ 11 prohibits narrowing conversions from `int` to `bool` in some contexts (list initialization). C has no `bool` type by default, only `_Bool`, which is not in C++ by default. So we end up with two definitions of `Bool_val`, one for C and one for C++. Fixes: #11332 (cherry picked from commit 14d9ab1)
Contributor
Author
|
Cherry-picked on 4.14 branch: c48b55e . |
ejgallego
pushed a commit
to ejgallego/ocaml
that referenced
this pull request
Nov 5, 2025
C++ 11 prohibits narrowing conversions from `int` to `bool` in some contexts (list initialization). C has no `bool` type by default, only `_Bool`, which is not in C++ by default. So we end up with two definitions of `Bool_val`, one for C and one for C++. Fixes: ocaml#11332 (cherry picked from commit 14d9ab1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ 11 makes it an error to convert automatically from
inttoboolin some contexts (list initialization). C has nobooltype by default, only_Bool, which is not in C++ by default. So we end up with two definitions ofBool_val, one for C and one for C++.Fixes: #11332