Add a test that detects a memory model violation#12854
Merged
Merged
Conversation
Contributor
Author
|
This PR is to stay in draft status, waiting for the detected bug to be fixed. |
Member
|
Okay, okay, I am working on a fix for #12825. |
maranget
force-pushed
the
bad-cse-test
branch
from
ef6589c to
f4e1397
Compare
introduced by too eager CSE.
maranget
force-pushed
the
bad-cse-test
branch
from
569e06d to
aba5606
Compare
maranget
force-pushed
the
bad-cse-test
branch
from
aba5606 to
6145e8d
Compare
gasche
approved these changes
Dec 26, 2023
gasche
left a comment
gasche
left a comment
Member
There was a problem hiding this comment.
The details of these memory-model tests are obscure to me, but I can tell from the patch that it was done carefully, and I like the idea of having a regression test for CSE issues. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug has been reported in issue #12825