Restore caml_runtime_parameters implementation in gc_ctrl.c#12963
Merged
dra27 merged 2 commits intoocaml:trunkfrom Feb 29, 2024
Merged
Restore caml_runtime_parameters implementation in gc_ctrl.c#12963dra27 merged 2 commits intoocaml:trunkfrom
dra27 merged 2 commits intoocaml:trunkfrom
Conversation
tmcgilchrist
force-pushed
the
caml_runtime_parameters_2
branch
2 times, most recently
from
9eddeb7 to
3be3e0e
Compare
ghost
approved these changes
Feb 7, 2024
dra27
reviewed
Feb 13, 2024
Member
dra27
left a comment
dra27
left a comment
There was a problem hiding this comment.
Thanks for looking at this - in passing in other headers, there are still bits of 4.x that need gradually tidying up, so it's nice to keep stepping towards a tidy runtime again 🙂
I think the omission of c from the result is probably a (very minor) bug in 4.x. Is there something I'm missing about t - it's just caml_params->trace_level now, isn't it?
tmcgilchrist
force-pushed
the
caml_runtime_parameters_2
branch
2 times, most recently
from
2faccad to
623e7b8
Compare
Contributor
Author
tmcgilchrist
force-pushed
the
caml_runtime_parameters_2
branch
2 times, most recently
from
acbe3d0 to
20f27d1
Compare
This primitive allows programs to query the runtime parameters supplied to an OCaml program.
tmcgilchrist
force-pushed
the
caml_runtime_parameters_2
branch
from
20f27d1 to
6337149
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore caml_runtime_parameters implementation in gc_ctrl.c. This primitive allows programs to query the runtime parameters supplied to an OCaml program.
caml_runtime_parametersis present in 4.14 but was left as a TODO during the multicore merge and has been missing since 5.0. This change restores the implementation to match the current documented options for OCAMLRUNPARAM.Additionally removes some extern symbols that were no longer used in gc_ctrl.c.