Manual: caution about custom block finalizers

[NickBarnes]

Small change to the manual emphasizing the existing warning about behaviour of custom block finalizers. Fixes #12820, in the sense that the problem there was caused by a finalizer calling caml_enter_blocking_section().

[edited to remove question answered by @shindere in comments]

[shindere]

Nick Barnes (2024/03/22 07:26 -0700):

Presumably no Changes entry required. Maybe there should be a formal way for non-committers to indicate their opinion on this when creating a PR?

There is. See file `HACKIGN.adoc`, lines 566 onwards: ``` `Changes updated` checks that the link:Changes[] file has been modified (hopefully to add a new entry). It can be disabled by including "_(no change entry needed)_" in one of your commit messages -- but in general all patches submitted should come with a Changes entry; see the guidelines in link:CONTRIBUTING.md[]. ```

[OlivierNicole]

Disclaimer: I don’t know much about finalisers, but the addition seems to be simply a forward reference (with some useful repetition) to a later paragraph, so I believe this is accurate.

[damiendoligez]

The CI failure is obviously not related to this PR. Merging.