Use the best native compiler available to build ocaml{doc,test}.opt #13048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These targets were depending on the bytecode compiler, which is obviously not correct.
shindere
changed the title
gasche
approved these changes
Mar 22, 2024
Member
gasche
left a comment
gasche
left a comment
There was a problem hiding this comment.
Thanks! I believe that this works as intended.
Member
|
Review-snap! |
gasche
added a commit
that referenced
this pull request
Mar 22, 2024
Use the best native compiler available to build ocaml{doc,test}.opt
(cherry picked from commit fcad286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #12921 by re-introducing the use of the
BEST_OCAMLOPTmechanism which had been forgotten during the merge of the corresponding
makefiles into the root one (second commit of this pull request).
The first commit fixes the dependencies of ocamldoc.opt and ocamltest.opt:
these two native programs were depending on ocamlc.opt, which is obviously
incorrect. This error seems to have been there from the beginning, see
commit 8486ca3 where there is likely a copy paste error between the
targets for ocamldoc and ocamldoc.opt, many thanks to @dra27 for
having done the investigation.