Skip to content

Conversation

@ncik-roberts
Copy link
Contributor

Extend the fix originally made in #1754 to be more airtight.

That PR has more context on why it's important for the forcing of lazy values to not be inlined when AFL instrumentation is enabled.

The present PR makes it obviously true that this comment (from just above the change) holds:

    (* Disable inlining optimisation if AFL instrumentation active,
       so that the GC forwarding optimisation is not visible in the
       instrumentation output.
       (see https://github.com/stedolan/crowbar/issues/14) *)

Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously correct.

@gasche gasche merged commit 03d47fd into ocaml:trunk May 1, 2024
xavierleroy added a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants