Cleanup compiler C flags used when compiling the systhreads library #13322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already dealt with by the build system, meaning that, before this commit, -g was actually occurring twice.
This is a leftover from 31cdf41, (part of ocaml#12589).
shindere
force-pushed
the
fix-systhreads-cflags
branch
from
f8a2058 to
d0590d8
Compare
dra27
approved these changes
Jul 19, 2024
Contributor
Author
|
Thank you so much for the prompt review/approval/merge!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR consists of two commits:
otherlibs/systhreads/Makefileshould not add-gto the CFLAGS since this is dealt with globally by the build system. So, before this commit-gwas passed twice when compilingst_stubs.c. With this commit-gis passed only once.