Add documentation for Runtime_events events#13382
Conversation
tmcgilchrist
left a comment
There was a problem hiding this comment.
This is a good improvement to the documentation, thank you. 👍🏻
Minor question, there is no corresponding event for caml_adjust_minor_gc_speed. Does it make sense to have one for that? It seemed out of place when caml_adjust_gc_speed emits an event and this one doesn't.
Lines 281 to 285 in 8bbb374
kayceesrk
left a comment
There was a problem hiding this comment.
This is much appreciated. Thank you.
Yes, I think this would be a good idea. |
|
I'd be happy to merge once https://github.com/ocaml/ocaml/pull/13382/files#r1722740060 is resolved. |
|
The CHANGES entry also needs to be updated. |
d49068a to
390bf18
Compare
|
I've updated the Changes file and squashed the commits at @sadiqj's request. |
Should be of interest to at least @kayceesrk and @tmcgilchrist
We could probably flesh these out further over time.