Merged
Conversation
garrigue
approved these changes
Oct 3, 2024
Contributor
garrigue
left a comment
garrigue
left a comment
There was a problem hiding this comment.
We discussed this PR online. It looks fine to me.
The label problem is a detail, but zero: sounds a bit algebraic.
Octachron
pushed a commit
that referenced
this pull request
Nov 28, 2024
Add closed_type_expr (cherry picked from commit c736287)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a tiny refactoring of
Ctype.free_variables. It looks like it would be more efficient, but really my motivation is to make aexists_free_variablefunction in the Jane Street branch. Making this PR here because I think this is a small improvement regardless.